Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax version range of plugin-threshold peerDependencies #859

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Relax version range of plugin-threshold peerDependencies #859

merged 1 commit into from
Mar 18, 2020

Conversation

pasieronen
Copy link
Contributor

What's Changing and Why

The threshold plugin has peer dependencies color/resize plugins ^0.8.0, which does not match 0.9.5, and install from scratch complains:

$ npm install @jimp/plugin-threshold @jimp/plugin-color @jimp/plugin-resize @jimp/custom
npm WARN @jimp/plugin-threshold@0.9.5 requires a peer of @jimp/plugin-color@^0.8.0 but none is installed. You must install peer dependencies yourself.
npm WARN @jimp/plugin-threshold@0.9.5 requires a peer of @jimp/plugin-resize@^0.8.0 but none is installed. You must install peer dependencies yourself.

This PR changes the peer dependency version to >0.8.0.

What else might be affected

Tasks

  • Add tests
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label

@crutchcorn
Copy link
Member

LGTM

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Mar 18, 2020
@hipstersmoothie hipstersmoothie merged commit dbd094f into jimp-dev:master Mar 18, 2020
@hipstersmoothie
Copy link
Collaborator

🚀 PR was released in v0.9.7 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants