Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nearly-all dev deps #799

Merged
merged 6 commits into from Sep 24, 2019
Merged

Upgrade nearly-all dev deps #799

merged 6 commits into from Sep 24, 2019

Conversation

crutchcorn
Copy link
Member

@crutchcorn crutchcorn commented Sep 21, 2019

What's Changing and Why

Upgrading dev deps, there should be no breaking changes to consumption

The only three dev deps were not updated were:

  • @types/yargs - seemed to break some type checks on CLI when doing so
  • ts-node - seemed to break some things in a build step when doing so, I know some tools rely on this via peer dep, so I assumed not upgrading for now would be best
  • @types/log-symbols - v3 turns into a shim type as v3 of the library added TS support https://github.com/sindresorhus/log-symbols/releases. However, v3 of the library also ups the required node version, which would mean a breaking change for jimp that I didn't want to introduce until more work on Uncaught ReferenceError: regeneratorRuntime is not defined #797

I also had to run xo --fix to fix some things that were added/changed somewhere in the linting process when upgrading eslint, prettier, I'm unsure

What else might be affected

This would drop support for any version of node > 8 for local dev

There seem to be new warnings for linting, but no errors

Published PR with canary version: 0.8.5-canary.799.447.0

@crutchcorn
Copy link
Member Author

crutchcorn commented Sep 21, 2019

@hipstersmoothie seems there is some issue with auto being released as-of-7.5 or 7.6. Seeing how you contributed to 7.4 I figured I'd give you a heads up before reverting it:

https://circleci.com/gh/oliver-moran/jimp/412

@hipstersmoothie hipstersmoothie added internal Changes only affect the internal API skip-release Preserve the current version when merged labels Sep 24, 2019
@hipstersmoothie hipstersmoothie merged commit 29679fa into jimp-dev:master Sep 24, 2019
@crutchcorn crutchcorn deleted the dev-dep-upgrade branch September 24, 2019 21:35
@hipstersmoothie
Copy link
Collaborator

🚀 PR was released in v0.8.5 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label Oct 18, 2019
@crutchcorn
Copy link
Member Author

@hipstersmoothie I don't mean to complain too much, but the CHANGELOG.md seems to have associated this PR as well as #800 to @popinguy

https://github.com/oliver-moran/jimp/blob/master/CHANGELOG.md#v085-fri-oct-18-2019

(The same on the Releases tab)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants