Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Perf Gains #622

Merged
merged 5 commits into from
Sep 19, 2018
Merged

Color Perf Gains #622

merged 5 commits into from
Sep 19, 2018

Conversation

hipstersmoothie
Copy link
Collaborator

What's Changing and Why

Mix Before:

1704.093ms
1641.440ms
1684.027ms
1890.238ms

Mix After

265.268ms
258.583ms
264.966ms
263.853ms

the following also received the same perf boost

  • tint
  • shade
  • xor
  • red
  • green
  • blue

All other function still fall back to tinycolor and take around 5x as long

closes #270

What else might be affected

Tests pass so I think we're good.

Tasks

  • Add tests
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label

@hipstersmoothie hipstersmoothie added the bug there is a bug in the way jimp behaves label Sep 19, 2018
@hipstersmoothie hipstersmoothie merged commit d45e4cf into jimp-dev:master Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug there is a bug in the way jimp behaves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mix functionality is too slow
1 participant