Print number #588
Merged
Print number #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hipstersmoothie
added
the
enhancement
hipstersmoothie
force-pushed
the
master
branch
from
4250a7a
to
61c5e2a
Compare
hipstersmoothie
force-pushed
the
print-number
branch
from
2a9689d
to
dda306a
Compare
edi9999
reviewed
Sep 1, 2018
packages/plugin-print/src/index.js
Outdated
| @@ -263,13 +259,14 @@ export default () => ({ | |||
| let alignmentX; | |||
| let alignmentY; | |||
|
|
|||
| if (typeof text === 'object') { | |||
| if (typeof text === 'object' && text.text) { | |||
There was a problem hiding this comment.
I think it should be :
if (typeof text === 'object' && typeof text.text === "string") {
since we would want : {text:''} , to not error.
|
@edi9999 I changed it it !== null so a user could still provide non string in the text object |
Closed
hipstersmoothie
force-pushed
the
print-number
branch
from
7b08b12
to
e354ae0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changing and Why
Allow print to print any type.
closes #568
What else might be affected
Tasks
jimp.d.ts