Monorepo #547
Merged
Monorepo #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hipstersmoothie
force-pushed
the
monorepo
branch
from
fdc381a
to
84c7265
Compare
hipstersmoothie
force-pushed
the
monorepo
branch
from
4a92845
to
8236c41
Compare
|
Ok, indeed it makes no sense to split encoder/decoder if the underlying libraries do not split them. Let me know when you've finished the new packages you've talked about |
|
@edi9999 all packages finished. once this is merged I'll make issues to document things a little more and get to work |
4 tasks
|
I’m going to merge in the next 24 hours. The tiff library is giving us a bunch of problems and this will help users be able to exclude that particular file type from their jimp |
|
Sorry for the late reply, I'm ok to merge too ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changing and Why
Breaks jimp up into a set of many packages. Great news is this doesn't break the API at all!
Types - plugins that enable encoding/decoding for a format:
@jimp/type-png@jimp/type-jpeg@jimp/type-bmp@jimp/type-tiff@jimp/type-gifMotiviation:
Plugins - plugins that enable encoding/decoding for a format:
@jimp/plugin-resize@jimp/plugin-rotate@jimp/plugin-crop@jimp/plugin-blitMotiviation:
Other Packages
@jimp/core- all the code you know and love from current jimp@jimp/custom- an API to customize a jimp configurationjimp- a customized jimp with all the current types and functionsTodo
Make all functions into packages that are also plugins. This will enable people to write plugins for jimp (like
circleor any other custom bitmap manipulation). It will also enable configuring a jimp the only does certain things.What else might be affected
Everything has been moved around so everthing
@edi9999 Input?
Tasks
jimp.d.ts