Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite Bug #546

Merged
merged 2 commits into from
Aug 13, 2018
Merged

Composite Bug #546

merged 2 commits into from
Aug 13, 2018

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Aug 12, 2018

What's Changing and Why

edge_crop wont try to guess pixels. edge_extend was resulting in the extra pixels mentioned in #406

fixes #406

NOTE: Still can't get these composite tests to work without writing to the filesystem.

What else might be affected

Compositing two images together where 1 is bigger than the other.

Tasks

  • Add tests
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label

@hipstersmoothie hipstersmoothie added the bug there is a bug in the way jimp behaves label Aug 12, 2018
@edi9999 edi9999 merged commit 76e69ad into jimp-dev:master Aug 13, 2018
@hipstersmoothie hipstersmoothie deleted the composite branch August 13, 2018 17:11
StephenGregory added a commit to StephenGregory/google-music-desktop-wallpapers that referenced this pull request Aug 17, 2018
Might remove the thin vertical white line along the right edge of some wallpapers.

Should fix #14 (see Jimp [PR #546](jimp-dev/jimp#546)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug there is a bug in the way jimp behaves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

composite outputs weird pixels to the bottom of the image
2 participants