Blendmodes #515
Merged
Blendmodes #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hipstersmoothie
added
the
enhancement
edi9999
reviewed
Aug 6, 2018
| @@ -422,44 +430,70 @@ export function composite(src, x, y, cb) { | |||
| return throwError.call(this, 'x and y must be numbers', cb); | |||
| } | |||
|
|
|||
| let { mode, opacitySource, opacityDest } = options; | |||
There was a problem hiding this comment.
Can you add a test with these new params ?
There was a problem hiding this comment.
test added! it's only 1 can be more thorough if needed
There was a problem hiding this comment.
I would prefer to have a test that will expect the whole image to be equal to a base image so that we have more certainty that it will break fast if the code is wrong (like you've done in : https://github.com/oliver-moran/jimp/pull/524/files#diff-c632bfb61a4e129216f938dcb8d1a782R126)
There was a problem hiding this comment.
@edi9999 I added a better test but for some reason my bitmaps were always off by 1 before writing. The new test writes to the filesystem and checks those buffers.
hipstersmoothie
force-pushed
the
blendmodes
branch
from
544c777
to
24f19ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changing and Why
Allows users to composite image in different ways similar to gimp.
closes #139
copied code from #191
What else might be affected
Nothing.
Tasks
jimp.d.ts