Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept height and width as strings #500

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

hipstersmoothie
Copy link
Collaborator

I wrote code to throw an error when the width and height are strings. But i was already parsing the int, so I think it's a better user experience if we just use the parsed values.

Updated 1 test to use string height and width

closes #340

@edi9999 edi9999 merged commit ba15d12 into jimp-dev:master Aug 1, 2018
@hipstersmoothie hipstersmoothie deleted the better-error branch August 5, 2018 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading error message on new Jimp(x, y, color)
2 participants