Add module build #492
Merged
Add module build #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edi9999 review please 😃 |
hipstersmoothie
force-pushed
the
module-buidl
branch
from
6d4643c
to
dca5e0b
Compare
edi9999
reviewed
Jul 30, 2018
| @@ -41,5 +41,9 @@ node_modules | |||
|
|
|||
| package-lock.json | |||
|
|
|||
| # Browser Version | |||
| browser/lib/*.js | |||
There was a problem hiding this comment.
I think the files should be deleted if they are in .gitignore (.gitignore only applies to additions, not to modifications)
There was a problem hiding this comment.
they were. it was actually just a whitespace issue. it was:
browser/lib/*.js (space at the end, not ignored)
changed to:
browser/lib/*.js (no space at the end, ignored)
There was a problem hiding this comment.
Good to merge?
There was a problem hiding this comment.
The file browser/lib/jimp.min.js is still in the repository in your Pull Request :
There was a problem hiding this comment.
oops! addressed this.
hipstersmoothie
force-pushed
the
module-buidl
branch
from
dca5e0b
to
00093b9
Compare
|
Added some docs too on the module build and using it with webpack too. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module build (still has import/export in output) for ESM and webpack. The future is now!
Also in this PR:
.babelrc.jsto determine babel setup far more easily without repeating oneselfbabel-preset-stage-0and add plugins we actually use. thestage-presets are being deprecated@babel/plugin-proposal-class-properties@babel/plugin-syntax-object-rest-spreadkarma-browserifyto make the test run ridiculously fast.browser-build.js(I want to delete most of this since we don't use much of it, another PR)babel-plugin-source-map-supportfor "development" env and not browserOld time running
npm run test: 43.04sNew time running
npm run test: 72s