-
-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format Code with Prettier and use Stricter Linter #464
Conversation
f1c27be
to
8e1aa1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in your changes, the files browser/lib/jimp.js should not be changed (they seem to be parsed by prettier/eslint)
.editorconfig
Outdated
# See http://editorconfig.org/ for valid options and editor plugins. | ||
|
||
# Prevents EditorConfig from searching higher in the tree | ||
root = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
editorconfig still makes sense (it is used so that from any text editor, you already have the config well setup for that project).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
putting it back
"browserify": "^14.3.0", | ||
"envify": "^3.4.0", | ||
"eslint": "^3.14.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why eslint-config-xo-react ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. fixing this. moving babel dep all to dev as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment has been addressed
more good ?
@edi9999 I'll exclude browser/lib/*.js in another PR. how does this one look now?
can you approve the changes? |
Thanks @hipstersmoothie ! |
@edi9999 Would you like to review?