Use latest jpeg-js package that fixes "unknown jpeg marker" error #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a little unsure about how much this PR changed the package-lock.json. If it seems like a problem, let me know and I can uncommit. |
|
different versions of npm produce different lock files, maybe it's that. I wouldn't worry about it too much - they're are quite painful to work with across distributed teams! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #177
When opening JPGs with fill bytes it will fail with the error "unknown JPEG marker ffff" even though it's a valid jpg. The issue has been fixed in the jpeg-js repo with this PR jpeg-js/jpeg-js#32.
These changes add no new linting issues but oiliver-moran/jimp:master seems to have linting issues on it's own, which I've ignored in this PR.