Fix #132 Failed to parse compiler message

[alopatindev]

No description provided.

[alopatindev]

Doesn't build with Rust 1.32.0

error[E0658]: use of unstable library feature 'maybe_uninit' (see issue #53491)
   --> /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/psm-0.1.11/src/lib.rs:197:40
    |
197 |     let mut callback: MaybeUninit<F> = MaybeUninit::new(callback);
    |                                        ^^^^^^^^^^^^^^^^

@oli-obk do we really want support the old compiler version? Thanks.

[oli-obk]

is this import really needed?

[alopatindev]

At least that's what serde documentation suggests:

You will want to provide some other way to protect against stack overflows, such as by wrapping your Deserializer in the dynamically growing stack adapter provided by the serde_stacker crate

I guess without it we're risking to run out of stack.

But in this particular case it works without serde_stacker anyway:

diff --git a/Cargo.toml b/Cargo.toml
index d028bec..642079e 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -11,7 +11,6 @@ edition = "2018"
 [dependencies]
 serde = { version = "1.0.107", features = ["derive"] }
 serde_json = { version = "1.0.59", features = ["unbounded_depth"] }
-serde_stacker = "0.1"

 [dependencies.semver]
 features = ["serde"]
diff --git a/src/messages.rs b/src/messages.rs
index 7884a00..9b4fceb 100644
--- a/src/messages.rs
+++ b/src/messages.rs
@@ -147,8 +147,7 @@ impl<R: BufRead> Iterator for MessageIter<R> {
         let message = line.map(|it| {
             let mut deserializer = serde_json::Deserializer::from_str(&it);
             deserializer.disable_recursion_limit();
-            let deserializer = serde_stacker::Deserializer::new(&mut deserializer);
-            Message::deserialize(deserializer).unwrap_or(Message::TextLine(it))
+            Message::deserialize(&mut deserializer).unwrap_or(Message::TextLine(it))
         });
         Some(message)
     }

What do you think: should we drop the dependence or not?

[alopatindev]

I wasn't able to reproduce stack overflow, so I'll add the change. Feel free to revert it if you want.

[oli-obk]

just adding a dependency will not help protect against stack overflows. I presume that you'd need to invoke something from that crate

[alopatindev]

let deserializer = serde_stacker::Deserializer::new(&mut deserializer);

Yes, that was the usage from the first commit

[oli-obk]

🤦 sorry, I totally overlooked that

[oli-obk]

I think bumping the minimal supported Rust version to 1.36 is ok

[alopatindev]

No need to update to 1.36 now 🎉