Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspace metadata field. #130

Merged
merged 4 commits into from Oct 12, 2020

Conversation

naerbnic
Copy link
Contributor

@naerbnic naerbnic commented Oct 5, 2020

This adds support for the new "metadata" field found at the workspace level.

Also, this eliminates the workspace and project metadata fields from being serialized if they are null.

@naerbnic
Copy link
Contributor Author

naerbnic commented Oct 9, 2020

There is still a failing test, but this one is tricky

Apparently by introducing a workspace object, the workspace_members field picks up all of the packages below the the top-level "all" package. This can potentially be fixed by changing the test (checking that there are 8 members in meta.workspace_members and possibly checking their names). This seems like something worth exercising in a test somewhere, however I think this may also be dropping already tested implementation.

From the maintainers perspective, would it be better to fit the test to the data, to rework the test to not accidentally include the other packages, or to create a separate test fixture for this?

For now, creating a CL which excludes the accidentally added workspace members in the tests/all/Cargo.toml file.

This prevents packages from accidentally being included in
workspace_members
@oli-obk oli-obk merged commit 98fc1e7 into oli-obk:main Oct 12, 2020
@oli-obk
Copy link
Owner

oli-obk commented Oct 12, 2020

I think the way you adjusted the test is totally fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants