Correct BuildScript.cfgs to be String rather than PathBuf #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robojumper
force-pushed
the
cfgs-string-not-pathbuf
branch
from
9230436
to
e84b58b
Compare
robojumper
changed the title
oli-obk
reviewed
May 4, 2020
robojumper
force-pushed
the
cfgs-string-not-pathbuf
branch
from
e84b58b
to
145c33a
Compare
robojumper
changed the title
|
Whoa that was fast :D Anyway, I just found the original addition, and it's likely an overzealous application of the discussion in #53 (comment) that caused this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the the cargo documentation which says:
Stringshould cover this.This is a breaking change.
ref rust-lang/rust-analyzer#4296