Some improvements to MetadataCommand #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows e.g. a `PathBuf` to be passed in without a clone happening.
No reason for this to be `&mut`.
oli-obk
reviewed
Apr 29, 2020
| @@ -496,7 +496,7 @@ impl MetadataCommand { | |||
| } | |||
|
|
|||
| /// Runs configured `cargo metadata` and returns parsed `Metadata`. | |||
| pub fn exec(&mut self) -> Result<Metadata> { | |||
| pub fn exec(&self) -> Result<Metadata> { | |||
There was a problem hiding this comment.
I understand the motiviation for this, but if it's not strictly necessary I'd like to withold it until the next major version bump. Please remove it from the PR and open an issue for it.
EDIT: well, actually all of this PR is a breaking change, but it's good changes, and unlikely to break anyone's use case. I think I'll just do another major bump soon.
|
Thanks! Is there any pressure on your side to see this as a released version soon? Or are you ok with accumulating more changes over a while before releasing? |
|
No immediate pressure! Totally ok to wait a bit. Thanks for checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execmethod&self.(The second one breaks API compat I believe, hope that's ok!)