Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPF installDir dialog is ignoring selectedfolder #1162

Closed
gasparovicm opened this issue May 13, 2022 · 4 comments
Closed

WPF installDir dialog is ignoring selectedfolder #1162

gasparovicm opened this issue May 13, 2022 · 4 comments
Labels
bug Done / Released

Comments

@gasparovicm
Copy link

When installation folder is selected by "Choose file" button/dialog, then path is ignored a and text in field is not changed.
When it is typed manually it works.
WinForm version works.
@oleg-shilo oleg-shilo added the bug label May 13, 2022
@oleg-shilo
Copy link
Owner

Indeed there is a mistake in the code behind.
It is in fact works as the selected value is passed to the msi session even if the text box is not updated visually.
But of course, it needs to be fixed.

@gasparovicm
Copy link
Author

I see . NotifyOfPropertyChange(() => InstallDirPath); is missing in set of property InstallDirPath in class InstallDirDialogModel. Ok. Temporary I will use my own fixed copy as custom dialog.

@oleg-shilo
Copy link
Owner

Bingo!
You can also use the WPF CustomUI project template so the source code for the dialogs will be in your codebase and put the fix there.

oleg-shilo added a commit that referenced this issue May 13, 2022
@oleg-shilo
- Issue #1162: WPF installDir dialog is ignoring selectedfolder

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6b9b6e3
@oleg-shilo
Copy link
Owner

Done.
Will be available in the very next release

oleg-shilo added a commit that referenced this issue May 15, 2022
@oleg-shilo
Release v1.20.1.0
0ff5afb 
- Issue #1162: WPF installDir dialog is ignoring selectedfolder
- Added `CommonTasks.RegisterComAssembly` to register COM servers.
- Issue #1132: Project.ResolveWildCards(ignoreEmptyDirectories: true) removes Start Menu shortcut
- Issue #118: Logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Done / Released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gasparovicm @oleg-shilo