Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide official sbt launch script as default #43

Merged
merged 1 commit into from Aug 2, 2021

Conversation

SethTisue
Copy link
Contributor

@SethTisue SethTisue commented Aug 1, 2021

also continue providing sbt-extras, but as sbtx

Olaf has already indicated (on Discord, I think it was?) that this change would be welcome

also continue providing sbt-extras, but as `sbtx`
@SethTisue
Copy link
Contributor Author

I haven't tested this, but the change seems pretty straightforward.

@SethTisue
Copy link
Contributor Author

fyi @dwijnand @eed3si9n

Copy link
Owner

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you! I’ll cut a new release later today.

@olafurpg olafurpg merged commit 0f46c34 into olafurpg:main Aug 2, 2021
@olafurpg
Copy link
Owner

olafurpg commented Aug 2, 2021

Release is out https://github.com/olafurpg/setup-scala/releases/tag/v13

@sideeffffect
Copy link
Contributor

Hello guys, may I ask what is the motivation for this change? 🙂

@olafurpg
Copy link
Owner

olafurpg commented Aug 2, 2021

@sideeffffect I think this PR fixes the issues here #35

@SethTisue
Copy link
Contributor Author

@sideeffffect see sbt/sbt#2889, where I have just left some fresh commentary (since this is bigger than just setup-scala)

@SethTisue SethTisue deleted the use-official-sbt-launch-script branch August 2, 2021 14:39
@SethTisue
Copy link
Contributor Author

SethTisue commented Aug 2, 2021

as for setup-scala specifically, I just noticed at https://github.com/olafurpg/setup-scala/releases/tag/v13 that it says:

csbt and sbtx launcher scripts will be removed in the next release. The official sbt script will be the only supported script going forward

that surprises me a bit, actually. I personally don't mind, but perhaps someone else will want to make a pitch for retaining the alternates?

@olafurpg
Copy link
Owner

olafurpg commented Aug 3, 2021

@SethTisue I’m not using those scripts and I don’t think other people are using them either. It would be nice to avoid installing those scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants