Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the shell option value should be optional instead of required #996

Merged
merged 1 commit into from Jul 24, 2021

Conversation

iiroj
Copy link
Member

@iiroj iiroj commented Jul 24, 2021

This fixes a bug introduced in #994 where any text after the --shell option was interpreted as its value, for example in --shell --relative the value was "--relative" instead of implied true.

This fixes a bug introduced in #994 where any text after the `--shell` option was interpreted as its value, for example in `--shell  --relative` the value was `"--relative"` instead of implied `true`.
@iiroj iiroj requested a review from okonet July 24, 2021 08:26
@iiroj
Copy link
Member Author

iiroj commented Jul 24, 2021

Ping @okonet I messed up the configuration of Commander a bit.

@codecov
Copy link

codecov bot commented Jul 24, 2021

Codecov Report

Merging #996 (b6bfa58) into master (fea8033) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #996   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          633       633           
  Branches       148       148           
=========================================
  Hits           633       633           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fea8033...b6bfa58. Read the comment docs.

@iiroj iiroj merged commit f7302f4 into master Jul 24, 2021
@iiroj iiroj deleted the fix-shell-option branch July 24, 2021 11:03
@github-actions
Copy link
Contributor

🎉 This PR is included in version 11.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants