New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow a path to be supplied to the --shell option (#993) #994
Conversation
Codecov Report
@@ Coverage Diff @@
## master #994 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 19 +1
Lines 612 633 +21
Branches 145 148 +3
=========================================
+ Hits 612 633 +21
Continue to review full report at Codecov.
|
What do you think, @okonet? I guess we could improve the error message for when the shell is incorrect, since now it just prints an
|
I think it’s fine unless it’s a simple change to add this information. |
I can try creating a simple |
Yeah, it was doable:
|
What do you think @okonet and @Kurt-von-Laven? Btw @okonet you need to approve the PR before I can merge it. |
🎉 This PR is included in version 11.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Just tested this out, and encountered the following error:
If I swap the order of the arguments, I instead get:
It appears that support for the case where no shell is specified was dropped in this PR, making this a breaking change rather than a simple feature release. How much work would it be to add back support for a boolean |
@Kurt-von-Laven thanks for detecting this, it seems the tests did not catch it! I'll see how it can be fixed. EDIT: It was a simple fix. Commander treats
|
This fixes a bug introduced in #994 where any text after the `--shell` option was interpreted as its value, for example in `--shell --relative` the value was `"--relative"` instead of implied `true`.
) This fixes a bug introduced in #994 where any text after the `--shell` option was interpreted as its value, for example in `--shell --relative` the value was `"--relative"` instead of implied `true`.
See issue #993 for info.