Husky to simple-git-hooks migration in mrm #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #954 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 611 611
Branches 144 144
=========================================
Hits 611 611 Continue to review full report at Codecov.
|
iiroj
approved these changes
Mar 22, 2021
|
@ai thanks for the PR! |
|
This looks great indeed. I didn't know about this package. |
This was referenced Mar 24, 2021
3 tasks
Closed
10 tasks
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mrmrecently migrarted fromhuskytosimple-git-hooks. I updated the text according to these changes.This
mrmmigration brought these benefits to users:simple-git-hookshas 0 dependencies and took 10 KB ofnode_modulesspace compared to 1 MB of husky 4.simple-git-hooksdoesn’t read config on everypre-commithook call which increases the performance. It uses the husky 5 model when you need explicitly to call a script on config changes. But it is a good trade-off forlint-stagedcase. It should give around a 0.5 second performance boost forpre-commit.Comparison with husky 5:
simple-git-hooksis smaller than husky 5.package.json.pinstdependency for Yarn 2.simple-git-hookshas out-of-the box Yarn 2 support.I already tested
simple-git-hookson Autoprefixer, PostCSS, Browserslist, and my commercial projects (with a big team). Everything works great. Other people reported about successful migration too. @toplenborensimple-git-hooksmaintainer is always open for the changes and answers quickly.