fix: run all git commands with submodule.recurse=false #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #888 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 599 602 +3
Branches 142 142
=========================================
+ Hits 599 602 +3
Continue to review full report at Codecov.
|
This explicitly prevents git commands from recursing into git submodules and thus causing issues with commands like stash or reset.
iiroj
force-pushed
the
fix-submodule-recurse
branch
from
a695237
to
ff46223
Compare
|
What do you think, @okonet? |
okonet
approved these changes
Jun 17, 2020
|
🎉 This PR is included in version 10.2.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This explicitly prevents git commands from recursing into git submodules and thus causing issues with commands like stash or reset.
Fixes #884