Allow to pass config instead of configPath #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #695 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 11 11
Lines 304 304
Branches 59 60 +1
=======================================
Hits 303 303
Misses 1 1
Continue to review full report at Codecov.
|
iiroj
requested changes
Aug 29, 2019
iiroj
previously approved these changes
Sep 2, 2019
|
Ping @okonet, care to take a look and merge? |
okonet
approved these changes
Sep 3, 2019
okonet
previously requested changes
Sep 3, 2019
|
Good point! We already have a section on the node api, so maybe add the config example there. |
|
Done |
|
Any chance to merge this? |
iiroj
requested changes
Sep 22, 2019
There was a problem hiding this comment.
Can you rebase on master and rename your commits to loosely match the Conventional Commits spec:
- feat: allow to pass config instead of configPath
- refactor: resolve config in same format as loadConfig
- docs: add docs
After this I can merge!
sheerun
force-pushed
the
config
branch
2 times, most recently
from
7ccff7b
to
bb37c68
Compare
|
done |
iiroj
approved these changes
Sep 22, 2019
|
🎉 This PR is included in version 9.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be very useful if someone wants to use lint-staged as library (me)