chore: upgrade to jest 23 #507
Conversation
| @@ -49,6 +49,8 @@ | |||
| "stringify-object": "^3.2.2" | |||
| }, | |||
| "devDependencies": { | |||
| "babel-core": "^6.26.3", | |||
| "babel-jest": "^23.6.0", | |||
There was a problem hiding this comment.
To work with yarn plug n play, it's important to not rely on hoising
| @@ -49,6 +49,8 @@ | |||
| "stringify-object": "^3.2.2" | |||
| }, | |||
| "devDependencies": { | |||
| "babel-core": "^6.26.3", | |||
There was a problem hiding this comment.
peer dep of babel-jest (due to us supporting both babel 6 and 7)
There was a problem hiding this comment.
Do you think it would be possible for us to remove babel from the project? I don't mind not using import but being more strict on what features are allowed. Last time it confused me a lot since tests are relying on it but source code doesn't
There was a problem hiding this comment.
Yeah, probably. Especially if you start using node 8, as you have object spread and async await out of the box 馃檪
There was a problem hiding this comment.
Yes, exactly. Here is the issue to track #508 ;)
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 12 12
Lines 243 243
Branches 29 29
=======================================
Hits 238 238
Misses 5 5Continue to review full report at Codecov.
|
|
Thanks a lot. Just today I was thinking about upgrading to use inline snapshots so it comes in handy :) |
Since you don't support node 4, it's safe to upgrade 馃檪
Using Jest 23 means that you can use e.g. https://github.com/jest-community/jest-watch-typeahead if you want