Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix stash still true when diff is not undefined #1259

Merged
merged 1 commit into from Feb 13, 2023

Conversation

yuzhanglong
Copy link
Contributor

fix: fix stash still true when diff is not undefined

fix: fix stash still true when diff is not undefined
@yuzhanglong
Copy link
Contributor Author

yuzhanglong commented Feb 10, 2023

stash isn't set to false when the '--diff' argument passed to the command line,the program will be wrong when pass the diff parameter:
image

because this MR has a bug:runAll() was called by lintStated(),but lintStated() has set stash = true by default,so stash = diff === undefined in runAll(),stash always true

@yuzhanglong
Copy link
Contributor Author

@iiroj

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (b250449) compared to base (f88b6b7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1259   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          735       735           
  Branches       198       198           
=========================================
  Hits           735       735           
Impacted Files Coverage Δ
lib/index.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iiroj iiroj merged commit 142c6f2 into lint-staged:master Feb 13, 2023
16 checks passed
@iiroj
Copy link
Member

iiroj commented Feb 13, 2023

Thanks @yuzhanglong ! I was sure I saw this change in the previous PR but must have been an oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants