Fix #1025 using git rev-parse to get the relative path inside git repo

[tkalmar]

Fix #1025
Idea for solution is from: pypa/setuptools_scm#415

[iiroj]

Thanks for the PR!

Since this is a platform-specific fix, could you change this to an if clause with a code comment on why this is necessary?

Something like:

if (gitRel) {
  // <reason>
  return ...
} else {
  // reason why not
  return ...
}

[codecov]

Codecov Report

Merging #1026 (e43880d) into master (32c08d3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1026   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          646       651    +5     
  Branches       146       148    +2     
=========================================
+ Hits           646       651    +5     

Impacted Files	Coverage Δ
lib/resolveGitRepo.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32c08d3...e43880d. Read the comment docs.

[iiroj]

Can you please edit the commit to include code comments explaining why this is necessary, according to this commit #1026 (comment)

This is only to make the code more readable and maintainable, thanks!

[tkalmar]

Done. Hope the intend is clearer now

[iiroj]

I will merge this as fix: detect git repo root correctly on cygwin

[iiroj]

Thank you for your contribution, @tkalmar!

[github-actions]

🎉 This PR is included in version 11.2.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This PR is included in version 11.3.0-beta.2 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀