Simplify Ignoring Files From .eslintignore. #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The README advised ESLint >= 7 users to install node-filter-async. Replace this suggestion with a simpler implementation requiring the same number of lines of code but no dependencies. Rename the variable eslintCli to eslint since it is an instance of the ESLint Node.js API as distinct from the ESLint CLI. Avoid instantiating the API when the files staged don't necessitate invocation of ESLint.
Codecov Report
@@ Coverage Diff @@
## master #1013 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 641 641
Branches 146 146
=========================================
Hits 641 641 Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 11.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 11.2.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 11.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README advised ESLint >= 7 users to install node-filter-async. Replace this suggestion with a simpler implementation requiring the same number of lines of code but no dependencies. Rename the variable
eslintClitoeslintsince it is an instance of the ESLint Node.js API as distinct from the ESLint CLI. Avoid instantiating the API when the files staged don't necessitate invocation of ESLint.