Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate paths before clearing dotfiles #261

Open
StandingPadAnimations opened this issue Jul 18, 2023 · 4 comments
Open

Validate paths before clearing dotfiles #261

StandingPadAnimations opened this issue Jul 18, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@StandingPadAnimations
Copy link

Is your feature request related to a problem? Please describe.
When trying this out today, it ended up deleting my dotfiles without making sym links (due to invalid paths that the tool only realized after deleting the dot files). I thankfully have a backup, but it was painful to restore and shouldn't be needed.

Describe the solution you'd like
Validate the final dotfile paths before deleting

Describe alternatives you've considered
There are none, I didn't even know this tool would delete dotfiles without validation

Additional context
This occurred while following the quick start guide

@HarlemSquirrel
Copy link

Yeah I see with the latest release 3.1.0 that my dotfiles are in a subdirectory are getting a "Path does not exist" and bombadil is playing tricks and deleting them from my repo directory. Good thing I have the git history!

@shaleh
Copy link

shaleh commented Mar 4, 2024

Can either of you provide a minimal example of bombadil not behaving as you expect? Something like "with this entry in the toml file and these files in the filesystem running link fails in this way". For instance @StandingPadAnimations did you have a typo or similar mistake in your toml file? Or were the files in your repo not in the paths the config expected?

@StandingPadAnimations
Copy link
Author

It's been a good while, but I do remember there not being typos in the path, rather the paths being wrong in general (if I recall correctly, I was confused by what the docs stated at the time regarding source vs target dirs)

@HarlemSquirrel
Copy link

HarlemSquirrel commented Mar 4, 2024

Well here's my current config that works fine with the latest main build but when using the last tagged release it deletes anything nested like config/alacritty

https://github.com/HarlemSquirrel/Dotfiles/blob/master/bombadil.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants