Avoid using RARRAY_PTR #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This macro marks the array as not protected by a write barrier which has negative effects on GC performance. As far as I could tell, all the uses in Oj are purely for read so we can use `RARRAY_CONST_PTR` which is effectively the same but doesn't unprotect the array.
ohler55
approved these changes
Feb 1, 2023
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This macro marks the array as not protected by a write barrier which has negative effects on GC performance.
As far as I could tell, all the uses in Oj are purely for read so we can use
RARRAY_CONST_PTRwhich is effectively the same but doesn't unprotect the array.cc @peterzhu2118