Skip to content

Add TruffleRuby into CI #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2022
Merged

Add TruffleRuby into CI #804

merged 1 commit into from
Jul 30, 2022
+99 −6

Conversation

Watson1978
Copy link
Collaborator

This PR will add TruffleRuby CI lane.
The failing tests are simply skipped now.

@stanhu stanhu mentioned this pull request Jul 30, 2022
Closed
@Watson1978 Watson1978 force-pushed the truffleruby branch 3 times, most recently from a2ff171 to 0e33551 Compare July 30, 2022 06:09
@ohler55 ohler55 merged commit 2ef95a9 into ohler55:develop Jul 30, 2022
@Watson1978 Watson1978 deleted the truffleruby branch July 31, 2022 04:24
@stanhu
Copy link
Contributor

stanhu commented Aug 1, 2022

@Watson1978 FYI, I had better luck with truffleruby+graalvm over truffleruby-head in #803. I'm not sure why, but perhaps @eregon has some ideas how to fix the seg fault and other issues that manifested in the tests.

eregon
eregon reviewed Aug 6, 2022
View reviewed changes
Copy link
Contributor

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding TruffleRuby in CI!
Looks like there are quite a few failures, will track them in oracle/truffleruby#2701

.github/workflows/CI.yml
strategy:
fail-fast: false
matrix:
ruby: [ '22.2.0' ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to test the latest truffleruby release, so just truffleruby here and ruby-version: ${{ matrix.ruby }} below (or just no matrix).

@eregon
Copy link
Contributor

eregon commented Aug 6, 2022

@Watson1978 FYI, I had better luck with truffleruby+graalvm over truffleruby-head in #803.

That's a release vs latest dev build. I expect it should be about the same between truffleruby+graalvm over truffleruby (both releases, both run in native mode, the default).

@eregon eregon mentioned this pull request Oct 5, 2022
Merged
@eregon
Copy link
Contributor

eregon commented Oct 5, 2022

Most skips removed in #817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon

@ohler55 ohler55

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Watson1978 @stanhu @eregon @ohler55