Make compaction available for Oj::Doc
#653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce compaction to `fast.c`, only if `rb_gc_mark_movable` is available. Otherwise, keep a version that supports ruby <2.7. Since `rb_data_object_wrap` and `TypedData_Wrap_Struct` is available in every supported versions (eg >=2.4.10), I've also removed support for earlier versions. Result for compaction is great. I've tested it by allocating and removing arbitrary sized json. For a count of 70 pages, we can see that we used to need 68 pages after compaction,and now 61 pages. Of course this test include also lots of noise, but if we count pinned objects (objects that are marked in C extension as uncollectible), we can see that for a benchmark with no allocations, we have the same amount as a benchmark with this commit with thousands of allocations (499 pinned objects total), and before this, `Oj::Doc` used to generate 5k more objects (5499 pinned objects total). Hence this is a win, see ohler55#650 for a graphical result. Signed-off-by: Ulysse Buonomo <buonomo.ulysse@gmail.com>
BuonOmo
commented
Apr 9, 2021
| @@ -328,7 +328,7 @@ def test_pipe | |||
| IO.pipe do |read_io, write_io| | |||
| if fork | |||
| write_io.close | |||
| Oj.sc_parse(handler, read_io) {|v| p v} | |||
| Oj.sc_parse(handler, read_io) | |||
There was a problem hiding this comment.
@ohler55 this one was outputing to tests, I looks like this was unwanted. Not 100% sure though
According to clang's documentation: > When using `-style=file`, **clang-format** for each input file will > try to find the `.clang-format` file located in the closest parent > directory of the input file. When the standard input is used, the > search is started from the current directory. Hence the `.clang-format` seems more appropriate Signed-off-by: Ulysse Buonomo <buonomo.ulysse@gmail.com>
|
I've also renamed the |
ohler55
approved these changes
Apr 9, 2021
|
Thanks for the additions and flexibility in getting it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce compaction to
fast.c, only ifrb_gc_mark_movableisavailable. Otherwise, keep a version that supports ruby <2.7.
Since
rb_data_object_wrapandTypedData_Wrap_Structis availablein every supported versions (eg >=2.4.10), I've also removed support
for earlier versions.
Result for compaction is great. I've tested it by allocating and
removing arbitrary sized json. For a count of 70 pages, we can see
that we used to need 68 pages after compaction,and now 61 pages. Of
course this test include also lots of noise, but if we count pinned
objects (objects that are marked in C extension as uncollectible),
we can see that for a benchmark with no allocations, we have the
same amount as a benchmark with this commit with thousands of allocations
(499 pinned objects total), and before this,
Oj::Docused to generate5k more objects (5499 pinned objects total).
Hence this is a win.
Here's the result of my tests after a
GC.compact(reddots are pinned objects):see #650 for scripts that generated these results.
Signed-off-by: Ulysse Buonomo buonomo.ulysse@gmail.com