Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new urlpath package for conversion #657

Merged
merged 4 commits into from Nov 3, 2022

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Nov 3, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 74.18% // Head: 73.73% // Decreases project coverage by -0.44% ⚠️

Coverage data is based on head (6f5bd92) compared to base (73ed92c).
Patch coverage: 20.65% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
- Coverage   74.18%   73.73%   -0.45%     
==========================================
  Files         170      171       +1     
  Lines       11905    11995      +90     
==========================================
+ Hits         8832     8845      +13     
- Misses       2613     2683      +70     
- Partials      460      467       +7     
Impacted Files Coverage Δ
internal/jsonpointer/resolve_ctx.go 92.00% <ø> (-0.11%) ⬇️
jsonschema/external.go 48.10% <0.00%> (-10.01%) ⬇️
internal/urlpath/urlpath.go 22.09% <22.09%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ernado ernado merged commit 75d24b0 into ogen-go:main Nov 3, 2022
@tdakkota tdakkota deleted the fix/resolve branch November 3, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants