Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAME_KEY is deprecated #72

Closed
ghost opened this issue Feb 19, 2019 · 2 comments
Closed

NAME_KEY is deprecated #72

ghost opened this issue Feb 19, 2019 · 2 comments

Comments

@ghost
Copy link

ghost commented Feb 19, 2019

As of emberjs/ember.js#16710,
NAME_KEY is deprecated. I think we just need to override the toString method on the controller mixin.
@ghost ghost mentioned this issue Feb 19, 2019
Merged
@scottkidder
Copy link
Contributor

Thanks @efx! 🎉 Looks to be resolved on master. Would be great to have a release cut to kill the deprecation noise.

@offirgolan
Copy link
Owner

Released under v1.0.1 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scottkidder @offirgolan