feat: add schemas for registry_package event, update package event with new information
#747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added this to Features
in
wolfy1339
commented
Dec 11, 2022
| @@ -33,138 +33,221 @@ | |||
| "ecosystem": { "type": "string" }, | |||
| "package_type": { | |||
| "type": "string", | |||
| "enum": ["npm", "maven", "rubygems", "docker", "nuget", "container"], | |||
| "enum": ["npm", "maven", "rubygems", "docker", "nuget", "CONTAINER"], | |||
There was a problem hiding this comment.
Can someone verify if all the other values are also in caps? The values aren't listed in the OpenAPI schema
There was a problem hiding this comment.
Where are you getting the caps from? I'm looking internally at some GitHub code and I see container is lower-cased, as are the rest of the values.
There was a problem hiding this comment.
It's the payload examples in octokit/webhooks.net#178
There was a problem hiding this comment.
Oh I see! That's interesting; I haven't found any instances internally that use the capitalized form.
wolfy1339
changed the title
registry_package event, update package event with new informationregistry_package event, update package event with new information
wolfy1339
changed the title
registry_package event, update package event with new informationregistry_package event, update package event with new information
G-Rath
reviewed
Dec 13, 2022
payload-schemas/api.github.com/common/package-npm-metadata.schema.json
Outdated
Show resolved
Hide resolved
kfcampbell
approved these changes
Dec 14, 2022
|
🎉 This PR is included in version 6.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
octokit/webhooks.js#646 will be resolved once the updates are merged there
ref: octokit/webhooks.net#178
Behavior
Before the change?
registry_packageevent was missingpackageevent was missing some information in the schemasAfter the change?
registry_packageevent is now presentpackageevent now validates properly against a recent payload (Payloads taken from [BUG]: Exceptions thrown when processingpackageevents webhooks.net#178 and have been anonymized)Other information
d25cb45, and from the payloadsAdditional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: Feature