Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent parameter naming: tag, tag_name #28

Open
1 task done
Richienb opened this issue Oct 28, 2020 · 2 comments
Open
1 task done

Inconsistent parameter naming: tag, tag_name #28

Richienb opened this issue Oct 28, 2020 · 2 comments
Labels
Status: Blocked Some technical or requirement is blocking the issue Type: Support Any questions, information, or general needs around the SDK or GitHub APIs
Projects

Comments

@Richienb
Copy link

Checklist

Versions

+-- @octokit/rest@18.0.6
| +-- @octokit/core@3.2.0
| | +-- @octokit/auth-token@2.4.2
| | +-- @octokit/graphql@4.5.6
| | +-- @octokit/request@5.4.9
| | | +-- @octokit/endpoint@6.0.8
| | | +-- @octokit/request-error@2.0.2
| | +-- @octokit/types@5.5.0
| +-- @octokit/plugin-paginate-rest@2.4.0
| +-- @octokit/plugin-request-log@1.0.2
| `-- @octokit/plugin-rest-endpoint-methods@4.2.0

What happened?

octokit.repos.createRelease uses tag_name but octokit.repos.getReleaseByTag uses tag.

What did you expect to happen?

They should be consistently named.

@gr2m
Copy link
Contributor

gr2m commented Oct 28, 2020

I'm afraid I cannot help with that. The methods are a 1:1 mapping of GitHub's REST API, with all its little flaws. See

It might be worth renaming the URL parameters. We did that in the past in order to make the REST API more coherent. That would need to be fixed in https://github.com/github/rest-api-description/, both the docs and the Octokit SDKs are generated from it. Would you like to file an issue there? No worries if not, I'll look into it eventually

@oscard0m
Copy link
Member

@gr2m gr2m changed the title Inconsistent tag parameter naming Inconsistent parameter naming: tag, tag_name Jan 24, 2021
@gr2m gr2m transferred this issue from octokit/octokit.js Apr 18, 2021
@gr2m gr2m added Status: Blocked Some technical or requirement is blocking the issue Type: Support Any questions, information, or general needs around the SDK or GitHub APIs labels Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Blocked Some technical or requirement is blocking the issue Type: Support Any questions, information, or general needs around the SDK or GitHub APIs
Projects
No open projects
JS
  
Blocked
Development

No branches or pull requests

3 participants