Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump minimal version of @octokit/plugin-paginate-rest to v2.16.4 to prevent typescript compile errors #120

Merged
merged 1 commit into from Sep 30, 2021

Conversation

webstech
Copy link
Contributor

Update package "@octokit/plugin-paginate-rest" to 2.16.4. While npm can update the package, it does not always do so and Typescript gets compile errors such as:

Property 'GET /user/{username}/packages' does not exist on type 'Endpoints'.

This should address issue #115 without user intervention required.

Update package "@octokit/plugin-paginate-rest" to 2.16.4.  While
npm can update the package, it does not always do so and Typescript
gets compile errors such as:

Property 'GET /user/{username}/packages' does not exist on
type 'Endpoints'.

Signed-off-by: Chris. Webster <chris@webstech.net>
@ghost ghost added this to Inbox in JS Sep 28, 2021
@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Sep 28, 2021
@ghost ghost moved this from Inbox to Bugs in JS Sep 28, 2021
@webstech webstech mentioned this pull request Sep 28, 2021
1 task
@wolfy1339 wolfy1339 changed the title Fix: Typescript compile failures for old package fix(deps): update @octokit/plugin-paginate-rest to v2.16.4 to fix typescript compile errors Sep 29, 2021
@wolfy1339 wolfy1339 requested a review from gr2m September 29, 2021 01:28
@gr2m gr2m changed the title fix(deps): update @octokit/plugin-paginate-rest to v2.16.4 to fix typescript compile errors fix(deps): bump minimal version of @octokit/plugin-paginate-rest to v2.16.4 to prevent typescript compile errors Sep 30, 2021
@gr2m gr2m merged commit fca1907 into octokit:master Sep 30, 2021
JS automation moved this from Bugs to Done Sep 30, 2021
@github-actions
Copy link
Contributor

🎉 This PR is included in version 18.11.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@webstech
Copy link
Contributor Author

Thank you to everyone involved. Not just for approving this change but the complete package(s).

@webstech webstech deleted the paginate-endpoints branch September 30, 2021 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
No open projects
JS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants