Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin version of node-fetch and add end-to-end test to catch breaking changes #432

Closed
gr2m opened this issue Sep 21, 2021 · 4 comments · Fixed by #580 or #586
Closed

pin version of node-fetch and add end-to-end test to catch breaking changes #432

gr2m opened this issue Sep 21, 2021 · 4 comments · Fixed by #580 or #586
Labels
Projects

Comments

@gr2m
Copy link
Contributor

gr2m commented Sep 21, 2021

This is in response to node-fetch/node-fetch#1300

@ghost ghost added this to Inbox in JS Sep 21, 2021
@gr2m gr2m added the Type: Feature New feature or request label Sep 21, 2021
@ghost ghost moved this from Inbox to Features in JS Sep 21, 2021
@eamodio
Copy link

eamodio commented Oct 4, 2021

Will this be moving to node-fetch 3? Or pinning v2? Hoping for the former. 😄

@gr2m
Copy link
Contributor Author

gr2m commented Oct 4, 2021

We’ll probably do both for some time, as we transition to ESM

@github-actions
Copy link

🎉 This issue has been resolved in version 7.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gr2m
Copy link
Contributor Author

gr2m commented May 21, 2023

We’ll probably do both for some time, as we transition to ESM

we ended up removing the dependency on node-fetch altogether via #432. It will be part of the v7 release. You can pass a custom fetch implementation e.g. for older Node versions or for mocking with https://github.com/wheresrhys/fetch-mock

@wolfy1339 wolfy1339 linked a pull request May 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
JS
  
Features
2 participants