Remove duplicated Faraday::Retry::Middleware: #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ### Problem
The Faraday::Retry::Middleware is added twice by Octokit when
instantiating the Faraday::RackBuilder object.
```sh
irb(main):001:0> Octokit.middleware
=>
#<Faraday::RackBuilder:0x0000000107898700
@adapter=Faraday::Adapter::NetHttp,
@handlers=
[Faraday::Retry::Middleware,
Faraday::Retry::Middleware,
...
```
### Context
The latest Faraday version in the 1.x serie added an alias
for `Faraday::Request::Retry`
https://github.com/lostisland/faraday/blob/824423ccbb534d0b0553c3a0b3f2fbb9b0d84c60/lib/faraday.rb#L33
### Solution
Use a elsif statement to avoid ending up with duplicated middleware
timrogers
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢 Hello, thanks for your work on maintaining Octokit 鉂わ笍 !
Remove duplicated Faraday::Retry::Middleware:
Problem
The Faraday::Retry::Middleware is added twice by Octokit when
instantiating the Faraday::RackBuilder object.
Context
The latest Faraday version in the 1.x serie added an alias
for
Faraday::Request::Retryhttps://github.com/lostisland/faraday/blob/824423ccbb534d0b0553c3a0b3f2fbb9b0d84c60/lib/faraday.rb#L33
Solution
Use a elsif statement to avoid ending up with duplicated middleware