Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Ruby 1.9.2 in Octokit::Client::Contents#create_contents #1442

Merged
merged 2 commits into from Jun 8, 2022

Conversation

timrogers
Copy link
Contributor

The #create_contents method currently has code, added for compatibility ruby Ruby 1.9.2, which uses different Base64 methods depending on the Ruby version.

This removes that code, since we don't support 1.9.2 and the .strict_encode64 method has been present since 1.9.3.

Fixes #1433.

…ents`

The `#create_contents` method currently has code, added for
compatability ruby Ruby 1.9.2, which uses different `Base64`
methods depending on the Ruby version.

This removes that code, since we don't support 1.9.2 and
the `.strict_encode64` method has been present since 1.9.3.

Fixes #1433.
@timrogers timrogers requested a review from nickfloyd June 8, 2022 11:31
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Way to be a solid scout for this gem! ❤️ 🗝️

@nickfloyd nickfloyd merged commit dd622a3 into 4-stable Jun 8, 2022
@nickfloyd nickfloyd deleted the base64 branch June 8, 2022 16:15
@nickfloyd nickfloyd added Type: Feature New feature or request and removed improvement labels Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for Ruby 1.9.2's version of Base64
2 participants