Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce client autoloads #1427

Closed
2 of 4 tasks
nickfloyd opened this issue Jun 6, 2022 · 4 comments
Closed
2 of 4 tasks

Reintroduce client autoloads #1427

nickfloyd opened this issue Jun 6, 2022 · 4 comments
Assignees
Labels
Status: Stale Used by stalebot to clean house Type: Feature New feature or request

Comments

@nickfloyd
Copy link
Contributor

nickfloyd commented Jun 6, 2022

RE: #1351 | #1425 | #1422 for more information

The original change for this PR was introduced in v4.23.0.

For the most part, this change is/was beneficial but after @collinsauve highlighted an issue that he was having as a result of this change we realized other areas where autoloading could cause issues due to modules not being loaded or load order even - details here.

  • We need to rollback the original PR and post another release (Reverts autoloading of modules change #1428)
  • Make a note in the original changelog of this issue
  • We need to consider optional ways to introduce this change (as part of the instantiation opts, etc...)
  • Reintroduce this change as an opt-in feature
@collinsauve
Copy link

Thanks for that investigation @nickfloyd - makes sense now why we were having this issue.

My 2 cents, though I'm just one of many users: We can probably work-around the breaking change, now that we know the cause. Calling it out in a changelog somewhere (with a documented workaround 🙏) would be helpful for others.

@nickfloyd
Copy link
Contributor Author

@collinsauve fantastic idea, once I get the "rollback" done I'll annotate the release notes. Thanks, and great catch!

@nickfloyd
Copy link
Contributor Author

Thanks for that investigation @nickfloyd - makes sense now why we were having this issue.

@timrogers was the one that finally tracked it down I believe (here). I'll reach out to him to get his thoughts on what he feels would be a good workaround to document for others might be.

@github-actions
Copy link

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Jul 26, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale Used by stalebot to clean house Type: Feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants