Get Octokit working with Ruby's immutable ("frozen") string literals functionality #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it works, then great, if not, we learned something.
In order to support --enable-frozen-literal, this change explicitly uses a mutable string - the unary plus does that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up @olleolleolle's work in #1354, getting Ruby's immutable ("frozen") string literal functionality working in Octokit.rb and enforcing that in our CI setup.
The one thing that has changed since the original PR - which I have to create as I am unable to contribute to the branch - is that a new version of the dependency
multipart-postgem has been released which makes it frozen string-compatible ❤️