Pass down ssl.verify to Faraday connection #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarebyte
requested changes
May 28, 2020
lib/octokit/connection.rb
Outdated
Comment on lines
178
to
180
| conn_opts[:ssl] ||= {} | ||
| conn_opts[:ssl][:verify_mode] ||= 0 if conn_opts.dig(:ssl, :verify) == false | ||
| conn_opts[:ssl][:verify_mode] ||= @ssl_verify_mode if @ssl_verify_mode |
There was a problem hiding this comment.
This feels pretty compact, and kind of difficult to read.
Would you mind putting it back to the same formatting as the original?
added 2 commits
June 2, 2020 09:25
This ensures adapters properly set SSL related options.
tarebyte
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures adapters properly set SSL related options.
Adapters like Typhoeus only check
options[:ssl][:verify].