Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coveralls is not working #1244

Closed
ybiquitous opened this issue Apr 14, 2020 · 2 comments · Fixed by #1245
Closed

Coveralls is not working #1244

ybiquitous opened this issue Apr 14, 2020 · 2 comments · Fixed by #1245

Comments

@ybiquitous
Copy link
Contributor

I noticed that the coveralls gem is not working on CI. See below:

https://github.com/octokit/octokit.rb/runs/583312202?check_suite_focus=true#step:6:26

Coveralls encountered an exception:
NoMethodError
undefined method `coverage' for #<SimpleCov::SourceFile:0x0000559805623520>
Did you mean?  coverage_data
/opt/hostedtoolcache/Ruby/2.6.6/x64/lib/ruby/gems/2.6.0/gems/coveralls-0.7.2/lib/coveralls/simplecov.rb:50:in `block in format'
/opt/hostedtoolcache/Ruby/2.6.6/x64/lib/ruby/2.6.0/forwardable.rb:230:in `each'
/opt/hostedtoolcache/Ruby/2.6.6/x64/lib/ruby/2.6.0/forwardable.rb:230:in `each'
/opt/hostedtoolcache/Ruby/2.6.6/x64/lib/ruby/gems/2.6.0/gems/coveralls-0.7.2/lib/coveralls/simplecov.rb:40:in `format'
/opt/hostedtoolcache/Ruby/2.6.6/x64/lib/ruby/gems/2.6.0/gems/simplecov-0.18.5/lib/simplecov/formatter/multi_formatter.rb:10:in `block in format'
/opt/hostedtoolcache/Ruby/2.6.6/x64/lib/ruby/gems/2.6.0/gems/simplecov-0.18.5/lib/simplecov/formatter/multi_formatter.rb:8:in `map'
/opt/hostedtoolcache/Ruby/2.6.6/x64/lib/ruby/gems/2.6.0/gems/simplecov-0.18.5/lib/simplecov/formatter/multi_formatter.rb:8:in `format'

The cause of the error seems that the coveralls gem does support the latest simplecov gem.
The simplecov gem had the API change with the v0.18.0.
See also simplecov-ruby/simplecov@6e7a9ab.

In addition, according to lemurheavy/coveralls-ruby#130, the coveralls gem seems unmaintained.

@indigok
Copy link

indigok commented Apr 14, 2020

Thanks for opening this up and adding all the context! We'll look at removing the coveralls dependency as it's not one we use much 🙇‍♀️

@janosrusiczki
Copy link

I logged an issue and a solution on the coveralls repo too.

lemurheavy/coveralls-ruby#161

The solution is to switch away from the official coveralls gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants