Support Ruby 2.7 #1243
Merged
Support Ruby 2.7 #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybiquitous
commented
Apr 14, 2020
|
👋@ybiquitous! Thanks for this update, the improvements look great. Unfortunately, we just merged a previous workflow PR #1206 and it created conflicts with this one. Our apologies for the extra work, but if you can update this PR we'd love to merge your changes as well ✨ |
It has been a few months since [Ruby 2.7 was released](https://www.ruby-lang.org/en/news/2019/12/25/ruby-2-7-0-released/). I think it's time we supported Ruby 2.7. This change adds Ruby 2.7 to our CI workflow (also small refactorings). In addition, this change fixes also the "Supported Ruby Versions" section in the README, because this section refers to Travis CI that is no longer used and describes older Ruby versions (<= 2.4) that are not tested. Note: The gemspec sets `required_ruby_version = '>= 2.0.0'` and it probably should be fixed together. But the gemspec change may break existing library users, so I don't it. Please give me more information about this if you have. https://github.com/octokit/octokit.rb/blob/002cba873b676af014a5de8ab3d8ea65a30c6edd/octokit.gemspec#L19 ```diff -required_ruby_version = '>= 2.0.0' +required_ruby_version = '>= 2.5.0' ```
ybiquitous
commented
Apr 15, 2020
| bundle install --path=.bundle/gems --without=development --jobs 4 --retry 3 | ||
| bundle config set path .bundle/gems | ||
| bundle config set without development | ||
| bundle install --jobs 4 --retry 3 |
There was a problem hiding this comment.
Fix deprecation warnings for Bundler 3.
See https://github.com/rubygems/bundler/blob/35be6d9a603084f719fec4f4028c18860def07f6/UPGRADING.md#cli-deprecations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been a few months since Ruby 2.7 was released.
I think it's time we supported Ruby 2.7.
This change adds Ruby 2.7 to our CI workflow (also small refactorings).
In addition, this change fixes also the "Supported Ruby Versions" section in the README,
because this section refers to Travis CI that is no longer used and describes older Ruby versions (<= 2.4) that are not tested.
Note
The gemspec sets
required_ruby_version = '>= 2.0.0'and it probably should be fixed together.But the gemspec change may break existing library users, so I don't it. Please give me more information about this if you have.
octokit.rb/octokit.gemspec
Line 19 in 002cba8
Updated
This PR merges PR #1206 that has added Ruby 2.7, so this PR actually modifies just the README description.
See also #1243 (comment)