From fc315ee924f18ab4f4d677ca74791ff310ed8876 Mon Sep 17 00:00:00 2001 From: Tim Rogers Date: Tue, 7 Jun 2022 18:30:15 +0100 Subject: [PATCH] Generate Rubocop todo list from changes which can't be autocorrected --- .rubocop.yml | 2 + .rubocop_todo.yml | 187 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 189 insertions(+) create mode 100644 .rubocop_todo.yml diff --git a/.rubocop.yml b/.rubocop.yml index 453f4e763..b204b5a70 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,3 +1,5 @@ +inherit_from: .rubocop_todo.yml + AllCops: NewCops: enable TargetRubyVersion: 2.3 diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml new file mode 100644 index 000000000..df5eac1bb --- /dev/null +++ b/.rubocop_todo.yml @@ -0,0 +1,187 @@ +# This configuration was generated by +# `rubocop --auto-gen-config` +# on 2022-06-07 17:29:45 UTC using RuboCop version 1.30.0. +# The point is for the user to remove these configuration records +# one by one as the offenses are removed from the code base. +# Note that changes in the inspected code, or installation of new +# versions of RuboCop, may require this file to be generated again. + +# Offense count: 1 +# Configuration parameters: Include. +# Include: **/*.gemspec +Gemspec/RequiredRubyVersion: + Exclude: + - 'octokit.gemspec' + +# Offense count: 13 +# Configuration parameters: AllowSafeAssignment. +Lint/AssignmentInCondition: + Exclude: + - 'lib/octokit/client/contents.rb' + - 'lib/octokit/client/feeds.rb' + - 'lib/octokit/client/gists.rb' + - 'lib/octokit/client/organizations.rb' + - 'lib/octokit/client/releases.rb' + - 'lib/octokit/client/stats.rb' + - 'lib/octokit/connection.rb' + - 'lib/octokit/error.rb' + - 'lib/octokit/response/raise_error.rb' + +# Offense count: 2 +# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches. +Lint/DuplicateBranch: + Exclude: + - 'lib/octokit/client/repositories.rb' + - 'lib/octokit/error.rb' + +# Offense count: 20 +# Configuration parameters: AllowComments, AllowNil. +Lint/SuppressedException: + Exclude: + - 'Rakefile' + - 'spec/helper.rb' + - 'spec/octokit/client/actions_secrets_spec.rb' + - 'spec/octokit/client/commits_spec.rb' + - 'spec/octokit/client/deployments_spec.rb' + - 'spec/octokit/client/hooks_spec.rb' + - 'spec/octokit/client/issues_spec.rb' + - 'spec/octokit/client/reactions_spec.rb' + - 'spec/octokit/client/refs_spec.rb' + - 'spec/octokit/client/repositories_spec.rb' + - 'spec/octokit/client/repository_invitations_spec.rb' + - 'spec/octokit/client/source_import_spec.rb' + +# Offense count: 31 +Lint/UselessAssignment: + Exclude: + - 'spec/octokit/client/actions_secrets_spec.rb' + - 'spec/octokit/client/actions_workflow_runs_spec.rb' + - 'spec/octokit/client/apps_spec.rb' + - 'spec/octokit/client/hooks_spec.rb' + - 'spec/octokit/client/organizations_spec.rb' + - 'spec/octokit/client/rate_limit_spec.rb' + - 'spec/octokit/client/releases_spec.rb' + - 'spec/octokit/client/repositories_spec.rb' + - 'spec/octokit/client/stats_spec.rb' + - 'spec/octokit/client_spec.rb' + - 'spec/octokit/enterprise_admin_client/search_indexing_spec.rb' + - 'spec/octokit/enterprise_admin_client/users_spec.rb' + - 'spec/octokit/enterprise_management_console_client/management_console_spec.rb' + +# Offense count: 1 +# Configuration parameters: CheckForMethodsWithNoSideEffects. +Lint/Void: + Exclude: + - 'lib/octokit/repo_arguments.rb' + +# Offense count: 13 +# Configuration parameters: IgnoredMethods, CountRepeatedAttributes. +Metrics/AbcSize: + Max: 33 + +# Offense count: 1 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. +# IgnoredMethods: refine +Metrics/BlockLength: + Max: 102 + +# Offense count: 2 +# Configuration parameters: CountComments, CountAsOne. +Metrics/ClassLength: + Max: 157 + +# Offense count: 7 +# Configuration parameters: IgnoredMethods. +Metrics/CyclomaticComplexity: + Max: 18 + +# Offense count: 25 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. +Metrics/MethodLength: + Max: 28 + +# Offense count: 4 +# Configuration parameters: CountComments, CountAsOne. +Metrics/ModuleLength: + Max: 213 + +# Offense count: 5 +# Configuration parameters: CountKeywordArgs. +Metrics/ParameterLists: + MaxOptionalParameters: 4 + Max: 9 + +# Offense count: 3 +# Configuration parameters: IgnoredMethods. +Metrics/PerceivedComplexity: + Max: 12 + +# Offense count: 1 +Naming/AccessorMethodName: + Exclude: + - 'lib/octokit/enterprise_management_console_client/management_console.rb' + +# Offense count: 1 +# Configuration parameters: ForbiddenDelimiters. +# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$)) +Naming/HeredocDelimiterNaming: + Exclude: + - 'lib/octokit/preview.rb' + +# Offense count: 1 +# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. +# AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to +Naming/MethodParameterName: + Exclude: + - 'lib/octokit/client/legacy_search.rb' + +# Offense count: 4 +# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns. +# SupportedStyles: snake_case, normalcase, non_integer +# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339 +Naming/VariableNumber: + Exclude: + - 'lib/octokit/error.rb' + +# Offense count: 3 +# Configuration parameters: AllowedConstants. +Style/Documentation: + Exclude: + - 'spec/**/*' + - 'test/**/*' + - 'lib/octokit/client/actions_workflow_runs.rb' + - 'lib/octokit/client/users.rb' + - 'lib/octokit/enterprise_management_console_client/management_console.rb' + +# Offense count: 5 +# Configuration parameters: MinBodyLength, AllowConsecutiveConditionals. +Style/GuardClause: + Exclude: + - 'lib/octokit.rb' + - 'lib/octokit/client/feeds.rb' + - 'lib/octokit/error.rb' + - 'lib/octokit/response/feed_parser.rb' + - 'lib/octokit/response/raise_error.rb' + +# Offense count: 5 +# This cop supports safe autocorrection (--autocorrect). +Style/IfUnlessModifier: + Exclude: + - 'lib/octokit.rb' + - 'lib/octokit/client.rb' + - 'lib/octokit/client/authorizations.rb' + - 'lib/octokit/client/organizations.rb' + +# Offense count: 2 +# Configuration parameters: AllowedMethods. +# AllowedMethods: respond_to_missing? +Style/OptionalBooleanParameter: + Exclude: + - 'lib/octokit/client/refs.rb' + +# Offense count: 100 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns. +# URISchemes: http, https +Layout/LineLength: + Max: 508