From 50bbe05ae36516fea6d0805013bf609a84956853 Mon Sep 17 00:00:00 2001 From: Tim Rogers Date: Tue, 7 Jun 2022 18:38:32 +0100 Subject: [PATCH] Generate Rubocop todo list from changes which can't be autocorrected --- .rubocop.yml | 2 + .rubocop_todo.yml | 239 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 241 insertions(+) create mode 100644 .rubocop_todo.yml diff --git a/.rubocop.yml b/.rubocop.yml index 15b38d111..79f1f1c51 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,3 +1,5 @@ +inherit_from: .rubocop_todo.yml + AllCops: TargetRubyVersion: 2.3 Metrics/BlockLength: diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml new file mode 100644 index 000000000..2a9ff434a --- /dev/null +++ b/.rubocop_todo.yml @@ -0,0 +1,239 @@ +# This configuration was generated by +# `rubocop --auto-gen-config` +# on 2022-06-07 18:38:27 +0100 using RuboCop version 0.81.0. +# The point is for the user to remove these configuration records +# one by one as the offenses are removed from the code base. +# Note that changes in the inspected code, or installation of new +# versions of RuboCop, may require this file to be generated again. + +# Offense count: 1 +# Configuration parameters: Include. +# Include: **/*.gemspec +Gemspec/RequiredRubyVersion: + Exclude: + - 'octokit.gemspec' + +# Offense count: 4 +Lint/AmbiguousOperator: + Exclude: + - 'lib/octokit/client.rb' + - 'lib/octokit/client/pub_sub_hubbub.rb' + - 'lib/octokit/connection.rb' + +# Offense count: 13 +# Configuration parameters: AllowSafeAssignment. +Lint/AssignmentInCondition: + Exclude: + - 'lib/octokit/client/contents.rb' + - 'lib/octokit/client/feeds.rb' + - 'lib/octokit/client/gists.rb' + - 'lib/octokit/client/organizations.rb' + - 'lib/octokit/client/releases.rb' + - 'lib/octokit/client/stats.rb' + - 'lib/octokit/connection.rb' + - 'lib/octokit/error.rb' + - 'lib/octokit/response/raise_error.rb' + +# Offense count: 20 +# Configuration parameters: AllowComments. +Lint/SuppressedException: + Exclude: + - 'Rakefile' + - 'spec/helper.rb' + - 'spec/octokit/client/actions_secrets_spec.rb' + - 'spec/octokit/client/commits_spec.rb' + - 'spec/octokit/client/deployments_spec.rb' + - 'spec/octokit/client/hooks_spec.rb' + - 'spec/octokit/client/issues_spec.rb' + - 'spec/octokit/client/reactions_spec.rb' + - 'spec/octokit/client/refs_spec.rb' + - 'spec/octokit/client/repositories_spec.rb' + - 'spec/octokit/client/repository_invitations_spec.rb' + - 'spec/octokit/client/source_import_spec.rb' + +# Offense count: 31 +Lint/UselessAssignment: + Exclude: + - 'spec/octokit/client/actions_secrets_spec.rb' + - 'spec/octokit/client/actions_workflow_runs_spec.rb' + - 'spec/octokit/client/apps_spec.rb' + - 'spec/octokit/client/hooks_spec.rb' + - 'spec/octokit/client/organizations_spec.rb' + - 'spec/octokit/client/rate_limit_spec.rb' + - 'spec/octokit/client/releases_spec.rb' + - 'spec/octokit/client/repositories_spec.rb' + - 'spec/octokit/client/stats_spec.rb' + - 'spec/octokit/client_spec.rb' + - 'spec/octokit/enterprise_admin_client/search_indexing_spec.rb' + - 'spec/octokit/enterprise_admin_client/users_spec.rb' + - 'spec/octokit/enterprise_management_console_client/management_console_spec.rb' + +# Offense count: 1 +# Configuration parameters: CheckForMethodsWithNoSideEffects. +Lint/Void: + Exclude: + - 'lib/octokit/repo_arguments.rb' + +# Offense count: 16 +# Configuration parameters: IgnoredMethods. +Metrics/AbcSize: + Max: 33 + +# Offense count: 1 +# Configuration parameters: CountComments, ExcludedMethods. +# ExcludedMethods: refine +Metrics/BlockLength: + Max: 102 + +# Offense count: 1 +# Configuration parameters: CountBlocks. +Metrics/BlockNesting: + Max: 4 + +# Offense count: 2 +# Configuration parameters: CountComments. +Metrics/ClassLength: + Max: 160 + +# Offense count: 7 +# Configuration parameters: IgnoredMethods. +Metrics/CyclomaticComplexity: + Max: 18 + +# Offense count: 29 +# Configuration parameters: CountComments, ExcludedMethods. +Metrics/MethodLength: + Max: 26 + +# Offense count: 4 +# Configuration parameters: CountComments. +Metrics/ModuleLength: + Max: 217 + +# Offense count: 4 +# Configuration parameters: CountKeywordArgs. +Metrics/ParameterLists: + Max: 9 + +# Offense count: 6 +# Configuration parameters: IgnoredMethods. +Metrics/PerceivedComplexity: + Max: 13 + +# Offense count: 1 +Naming/AccessorMethodName: + Exclude: + - 'lib/octokit/enterprise_management_console_client/management_console.rb' + +# Offense count: 1 +# Configuration parameters: ForbiddenDelimiters. +# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$)) +Naming/HeredocDelimiterNaming: + Exclude: + - 'lib/octokit/preview.rb' + +# Offense count: 1 +# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. +# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp +Naming/MethodParameterName: + Exclude: + - 'lib/octokit/client/legacy_search.rb' + +# Offense count: 9 +# Configuration parameters: AllowedChars. +Style/AsciiComments: + Exclude: + - 'lib/octokit/client/contents.rb' + - 'lib/octokit/client/gists.rb' + - 'lib/octokit/client/licenses.rb' + - 'lib/octokit/client/organizations.rb' + - 'lib/octokit/client/repositories.rb' + - 'lib/octokit/client/stats.rb' + - 'lib/octokit/client/users.rb' + - 'lib/octokit/middleware/follow_redirects.rb' + +# Offense count: 484 +Style/CommentedKeyword: + Enabled: false + +# Offense count: 3 +Style/Documentation: + Exclude: + - 'spec/**/*' + - 'test/**/*' + - 'lib/octokit/client/actions_workflow_runs.rb' + - 'lib/octokit/client/users.rb' + - 'lib/octokit/enterprise_management_console_client/management_console.rb' + +# Offense count: 7 +Style/DoubleNegation: + Exclude: + - 'lib/octokit/authentication.rb' + - 'lib/octokit/client/repositories.rb' + - 'lib/octokit/configurable.rb' + - 'spec/helper.rb' + +# Offense count: 7 +# Configuration parameters: MinBodyLength. +Style/GuardClause: + Exclude: + - 'lib/octokit.rb' + - 'lib/octokit/client/feeds.rb' + - 'lib/octokit/error.rb' + - 'lib/octokit/repository.rb' + - 'lib/octokit/response/feed_parser.rb' + - 'lib/octokit/response/raise_error.rb' + +# Offense count: 1 +# Configuration parameters: AllowIfModifier. +Style/IfInsideElse: + Exclude: + - 'lib/octokit/connection.rb' + +# Offense count: 22 +# Cop supports --auto-correct. +Style/IfUnlessModifier: + Exclude: + - 'lib/octokit.rb' + - 'lib/octokit/client.rb' + - 'lib/octokit/client/authorizations.rb' + - 'lib/octokit/client/commits.rb' + - 'lib/octokit/client/organizations.rb' + - 'lib/octokit/client/repositories.rb' + - 'lib/octokit/default.rb' + - 'lib/octokit/enterprise_management_console_client/management_console.rb' + - 'lib/octokit/error.rb' + - 'lib/octokit/repository.rb' + - 'spec/helper.rb' + +# Offense count: 1 +Style/MultilineTernaryOperator: + Exclude: + - 'lib/octokit/client/contents.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods. +# SupportedStyles: predicate, comparison +Style/NumericPredicate: + Exclude: + - 'spec/**/*' + - 'lib/octokit/connection.rb' + +# Offense count: 1 +Style/StructInheritance: + Exclude: + - 'lib/octokit/rate_limit.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Style/WhileUntilModifier: + Exclude: + - 'spec/octokit/client/source_import_spec.rb' + +# Offense count: 1290 +# Cop supports --auto-correct. +# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# URISchemes: http, https +Layout/LineLength: + Max: 517