Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Do we have the CJS version? If not, are we considering supporting CJS? #2668

Closed
1 task done
shen774411223d opened this issue May 6, 2024 · 5 comments
Closed
1 task done
Labels
Status: Triage This is being looked at and prioritized Type: Feature New feature or request

Comments

@shen774411223d
Copy link

Describe the need

My project is based on CJS and I want to import octokit.js, but it is not compatible with ESM.

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@shen774411223d shen774411223d added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels May 6, 2024
Copy link

github-actions bot commented May 6, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member

This package is still CJS, it hasn't moved to ESM yet. It will be the last major version to support CJS

@wolfy1339 wolfy1339 closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
@shen774411223d
Copy link
Author

sorry, but i install lastest version. in octokit/core package.json, the type is module.
why i install package not cjs?
thank you answer!

octokit/core package.json

{
  "type": "module"
}

@wolfy1339
Copy link
Member

That is a different package, and a different repository.

You need to use the last CJS version, which is https://github.com/octokit/core.js/releases/tag/v5.2.0

@shen774411223d
Copy link
Author

Thank you very much for your answer. This is exactly the package I want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage This is being looked at and prioritized Type: Feature New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants