fix: use "secondary" instead of "abuse" for rate limit

[nimadini]

GitHub renamed abuse limits to secondary rate limits in 2021:
https://docs.github.com/en/rest/overview/resources-in-the-rest-api#secondary-rate-limits

@octokit/plugin-throttling followed suit in March 2022, and released
version 3.6.0 with this new name (and deprecated onAbuseLimit):
octokit/plugin-throttling.js#455

This commit updates the codebase to use the new name.

---

View rendered README.md

[wolfy1339]

Could you follow the same changes as in @octokit/plugin-throttling, and add an alias for the old name that logs a deprecation message.

[gr2m]

Could you follow the same changes as in @octokit/plugin-throttling, and add an alias for the old name that logs a deprecation message.

I think the deprecation message should already be shown, as the options are simply passed through to @octokit/plugin-throttling. Can you confirm @nimadini?

[nimadini]

Thanks for the quick review!

I confirmed the deprecation message (from @octokit/plugin-throttling) is printed when a secondary rate limit is hit.

To test it, I pointed my Octokit client to a dummy server that returns a 403 with an error message that has the secondary rate keyword in it. (See https://gist.github.com/nimadini/516b82ff69e374259ce23909c1a6f6da for details.)

Maybe an earlier place @octokit/plugin-throttling could warn users is during construction of the Octokit client, instead of later on when the secondary rate limit is hit. Specially because by design @octokit/plugin-throttling implements GitHub's best practices to avoid hitting the secondary rate limit in the first place (and it does a great job at that). So in practice, this warning message may never be shown to the user. 🙂

[nimadini]

Confirmed above @gr2m. 🙂 Can you please take another look when you have a minute?

[github-actions]

🎉 This PR is included in version 2.0.5 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀