Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Friendly API for uploading release assets #27

Open
1 task done
alexrp opened this issue Jan 4, 2024 · 2 comments
Open
1 task done

[FEAT]: Friendly API for uploading release assets #27

alexrp opened this issue Jan 4, 2024 · 2 comments
Labels
Type: Design Considerations Anything from maintainers/contributors that will help shape this SDK Type: Feature New feature or request

Comments

@alexrp
Copy link

alexrp commented Jan 4, 2024

Describe the need

I might have missed it, but there doesn't appear to be a friendly API for uploading release assets. In Octokit, this was done like so:

var releaseApi = ghc.Repository.Release;
var release = await releaseApi.Get(...);
await releaseApi.UploadAsset(release, new ReleaseAssetUpload(zipFileName, MediaTypeNames.Application.Zip, stream, timeout));

It would be nice if Octokit.NET.SDK had something similar rather than requiring me to make a manual request using the Release.UploadUrl.

SDK Version

v0.0.3

API Version

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@alexrp alexrp added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Jan 4, 2024
Copy link

github-actions bot commented Jan 4, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@nickfloyd nickfloyd removed the Status: Triage This is being looked at and prioritized label Jan 8, 2024
@nickfloyd
Copy link
Contributor

Hey @alexrp,

Thanks for reaching out. You're touching on an aspect of the generated SDKs that we will be addressing in the months to come. Composite SDKs. We will be leaning more into these as we get use cases from the community and gather all of our leanings from the more than a decade of learning on our existing SDKs.

Thank you for highlighting this use case! We'll add it to the others that we're planning on having a look at implementing. With that said, we would be more than glad to get a PR from you and others on how this might look as an implementation in this new SDK!

@nickfloyd nickfloyd added the Type: Design Considerations Anything from maintainers/contributors that will help shape this SDK label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Design Considerations Anything from maintainers/contributors that will help shape this SDK Type: Feature New feature or request
Projects
Status: 🔖 Ready
Development

No branches or pull requests

2 participants