Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PhpUnit version in composer.json #3532

Closed
Ognj3n opened this issue Apr 28, 2018 · 5 comments
Closed

Update PhpUnit version in composer.json #3532

Ognj3n opened this issue Apr 28, 2018 · 5 comments

Comments

@Ognj3n
Copy link

Ognj3n commented Apr 28, 2018

The latest stable version of PhpUnit is 7.*.

However installation source code requires 5.7 PhpUnit version, which can make debugging of PhpUnit tests pretty messy for first timers in October CMS.

Will be glad to see this updated.

@LukeTowers
Copy link
Contributor

@Ognj3n feel free to make a PR to octobercms/october and octobercms/library and any RainLab plugins using unit testing to upgrade the version.

@viamage
Copy link
Contributor

viamage commented Jun 5, 2018

Latest PhpUnit is 7.x, but php-selenium requires php-unit <7, so 6.5 I guess.

I wonder if we should wait for giorgiosironi/phpunit-selenium#422 or upgrade to 6.x for now? I guess we can proceed with 6.x to resolve #3360 at least.

EDIT:
Ah actually #3051 pulling this would resolve it and make us able to go for phpunit7

@github-actions
Copy link

This issue will be closed and archived in 3 days, as there has been no activity in the last 30 days. If this issue is still relevant or you would like to see action on it, please respond and we will get the ball rolling.

@w20k
Copy link
Contributor

w20k commented Oct 10, 2019

Was upgraded by @bennothommo to 6.5 version (https://github.com/octobercms/october/blob/master/composer.json#L46)
The next major upgrade will be, most probably done, after migration to a Laravel 6.0.

@bennothommo
Copy link
Contributor

Upgraded to PHPUnit 8 as part of #4893.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants