Adds support for blake2x by allowing max_depth 0 #12
+129
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Could you make the corresponding change on the |
|
Of course! |
kobigurk
changed the title
|
Pushed, added test vectors from the kat. |
oconnor663
requested changes
Sep 3, 2019
There was a problem hiding this comment.
This is fantastic. I'm really glad to see those BLAKE2X* test vectors getting exercised. A few more nits for the new test code, and then I think this will be ready to merge. Let me know if you'd prefer for me to just go ahead and merge it and make these changes on my end.
|
Thanks for all the great comments. I updated it! |
|
Absolutely, really glad to have this change and especially these tests. If you need this in production I could go ahead and tag a release? |
|
Yes, I would love it to be tagged, I do want to use it in a live project :)
…On Thu, Sep 5, 2019 at 8:07 PM oconnor663 ***@***.***> wrote:
Absolutely, really glad to have this change and especially these tests. If
you need this in production I could go ahead and tag a release?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12?email_source=notifications&email_token=AA23MGAXKS2S77Z4BXB4FPLQIE4FFA5CNFSM4ISXBGO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD576UTY#issuecomment-528476751>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA23MGDE5ZSTDNSPF3UIILDQIE4FFANCNFSM4ISXBGOQ>
.
|
|
Done! Version 0.5.8 is live. |
|
Awesome! Already using it.
…On Thu, Sep 5, 2019 at 9:19 PM oconnor663 ***@***.***> wrote:
Done! Version 0.5.8 is live.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12?email_source=notifications&email_token=AA23MGCUZQYKO5JPJ4WESU3QIFETNA5CNFSM4ISXBGO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6AG77A#issuecomment-528510972>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA23MGC4LCZ6NZZ4TOJYNSLQIFETNANCNFSM4ISXBGOQ>
.
|
|
Please send me a link to what you're building with it, if it's public. |
|
Here you go: https://github.com/celo-org/bls-zexe
<celo-org/celo-bls-snark-rs#62>
Specifically, I use the new version in:
celo-org/celo-bls-snark-rs#62
…On Thu, Sep 5, 2019 at 9:36 PM oconnor663 ***@***.***> wrote:
Please send me a link to what you're building with it, if it's public.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12?email_source=notifications&email_token=AA23MGGOLUESDNZDW7337KTQIFGRVA5CNFSM4ISXBGO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6AITXA#issuecomment-528517596>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA23MGGVJG7XG6SNFKGFRZLQIFGRVANCNFSM4ISXBGOQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to support Blake2x (https://blake2.net/blake2x.pdf).
The PR also adds testing for blake2x using the reference implementation test vectors.